Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): verify_privilege need check privilege one by one #15105

Merged
merged 1 commit into from Mar 28, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Mar 27, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

verify_privilege need fold same GrantEntry

E.g.

grant insert on default.* to role role1;
grant delete on default.t to u1;
grant role role1 to u1;

-- login in with u1; -- need success.
insert overwrite t values(100) 
  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 27, 2024
Copy link
Member

@flaneur2020 flaneur2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TCeason TCeason marked this pull request as draft March 27, 2024 06:07
@TCeason TCeason changed the title fix(query): verify_privilege need fold same GrantEntry fix(query): verify_privilege need check privilege one by one Mar 27, 2024
@TCeason TCeason force-pushed the grant branch 9 times, most recently from a93bc1a to 6a0e5f4 Compare March 27, 2024 07:39
@TCeason TCeason marked this pull request as ready for review March 27, 2024 07:40
Copy link
Member

@flaneur2020 flaneur2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@BohuTANG BohuTANG merged commit 9c33113 into datafuselabs:main Mar 28, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants