Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(executor): remove duplicate profile statistics #15115

Merged
merged 1 commit into from Mar 28, 2024

Conversation

zhang2014
Copy link
Member

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(executor): remove duplicate profile statistics

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 28, 2024
@zhang2014 zhang2014 requested a review from BohuTANG March 28, 2024 06:58
Copy link

what-the-diff bot commented Mar 28, 2024

PR Summary

  • Removal of Specific Fields from PlanProfile Structure
    Several attributes or fields from the 'PlanProfile' data structure namely cpu_time, wait_time, exchange_rows, and exchange_bytes have been removed. This essentially means that the data related to these aspects won't be stored in the structure anymore.

  • Update to load_profile and merge Functions
    Corresponding changes have been made in two functions: load_profile and merge as part of the 'PlanProfile' block. Specifically, those parts of code in these functions that dealt with the aforementioned fields have been taken out. The functions will now work without considering these parameters, leading to a slightly different way of executing tasks.

@BohuTANG BohuTANG disabled auto-merge March 28, 2024 07:17
@BohuTANG BohuTANG merged commit 470dad8 into datafuselabs:main Mar 28, 2024
64 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants