Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): only intercept dml and queries in queries queue #15143

Merged
merged 9 commits into from Apr 2, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Mar 31, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

limit the concurrency of Databend-query is only effective for queries(select, update, delete, insert, replace, merge into). when sql is query and queue is full, it will be queued to wait.

SELECT the system database will not be affected, which means that when queue is full, we can also get queued queries through 'select * from system. queries_queue'

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 31, 2024
@zhang2014 zhang2014 marked this pull request as ready for review April 1, 2024 14:00
@youngsofun
Copy link
Member

why we still need entry for plans that not need to acquire?

@zhang2014
Copy link
Member Author

why we still need entry for plans that not need to acquire?

queue is abstract and may also have queue management for other operations.

@BohuTANG BohuTANG merged commit ca8c20b into datafuselabs:main Apr 2, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants