Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove no longer used message encoding benchmark #15148

Merged
merged 1 commit into from Apr 1, 2024
Merged

chore: remove no longer used message encoding benchmark #15148

merged 1 commit into from Apr 1, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Apr 1, 2024 •
edited

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

The benchmark of various encoding schemas (of table meta) is no longer needed. it brings troubles to the clippy phase of PR #15147.

let's remove it.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - pure refactor

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 1, 2024
@dantengsky dantengsky force-pushed the chore-remove-encode-benchmark branch from 9ec11ee to 1a3caf3 Compare April 1, 2024 06:07
@dantengsky dantengsky marked this pull request as ready for review April 1, 2024 06:34
@dantengsky dantengsky added this pull request to the merge queue Apr 1, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Apr 1, 2024
@BohuTANG BohuTANG merged commit 7891778 into datafuselabs:main Apr 1, 2024
78 checks passed
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkyFan2002 SkyFan2002 SkyFan2002 approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dantengsky @SkyFan2002 @BohuTANG