Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support to add random seed on random engine #15167

Merged
merged 5 commits into from Apr 8, 2024

Conversation

blackstar-baba
Copy link
Contributor

@blackstar-baba blackstar-baba commented Apr 4, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Syntax:

create table t(a int, time timestamp) Engine=Random SEED=1000;
select * from t; -- -- this will use seed 1000 to generate random values.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Apr 4, 2024
@blackstar-baba
Copy link
Contributor Author

I will add some test cases.

@blackstar-baba blackstar-baba reopened this Apr 4, 2024
@PsiACE
Copy link
Member

PsiACE commented Apr 4, 2024

Cool, after this PR, more reproducible examples can be added to sqllogictest.

@BohuTANG
Copy link
Member

BohuTANG commented Apr 8, 2024

@blackstar-baba Good job!
It's would be great to add how to use it in the PR summary.

@BohuTANG
Copy link
Member

BohuTANG commented Apr 8, 2024

@blackstar-baba Good job! It's would be great to add how to use it in the PR summary.

Updated the PR summary.

@BohuTANG BohuTANG merged commit 33ea94f into datafuselabs:main Apr 8, 2024
78 checks passed
@blackstar-baba
Copy link
Contributor Author

@blackstar-baba Good job! It's would be great to add how to use it in the PR summary.

Updated the PR summary.

Modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support to add random seed on random engine
4 participants