Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): fix boolean type comparison #15171

Merged
merged 2 commits into from Apr 7, 2024

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Apr 5, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Currently the comparison result of false >= false/false <= false is false, but the result should be true.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 5, 2024
@Dousir9 Dousir9 requested a review from sundy-li April 7, 2024 01:38
@Dousir9 Dousir9 marked this pull request as ready for review April 7, 2024 01:38
@Dousir9 Dousir9 requested a review from andylokandy April 7, 2024 03:19
@Dousir9 Dousir9 added this pull request to the merge queue Apr 7, 2024
Merged via the queue into datafuselabs:main with commit d1cc550 Apr 7, 2024
87 checks passed
@Dousir9 Dousir9 deleted the fix_boolean_comparison branch April 7, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants