Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): show grants panic when role/user has immute db/table privilege #15188

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Apr 9, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

show grants panic when role/user has immute db/table privilege

The mutetable catalog mget need discard the immuteable db/table id.

If not, will generate vec out of index.

Easy way to reproduce

create role role3;
grant select on system.one to role role3;
show grants for role role3;

So in this pr, we split the db/table id in DatabaseCatalog

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Apr 9, 2024
@BohuTANG BohuTANG merged commit 614c0bc into datafuselabs:main Apr 10, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: show grants panic when role/user has immute db/table privilege
2 participants