Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): implement ST_MAKEPOLYGON #15194

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

kkk25641463
Copy link
Contributor

@kkk25641463 kkk25641463 commented Apr 9, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat: Implement ST_MAKEPOLYGON(). see alse doc.
other: remove to_geometry alias,becasue register_aliases() only depend on alias_name as key which will cause the registered function to be overwritten.

    pub fn register_aliases(&mut self, fn_name: &str, aliases: &[&str]) {
        for alias in aliases {
            self.aliases.insert(alias.to_string(), fn_name.to_string());
        }
    }
    registry.register_aliases("st_geometryfromwkb", &[
        "to_geometry",
    ]);
    registry.register_aliases("st_geometryfromwkt", &[
        "to_geometry",
    ]);

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Apr 9, 2024
Signed-off-by: Fan Yang <yangfanlinux@gmail.com>
@sundy-li sundy-li added this pull request to the merge queue Apr 10, 2024
Merged via the queue into datafuselabs:main with commit 24c14ff Apr 10, 2024
72 checks passed
@kkk25641463 kkk25641463 deleted the ST_MAKEPOLYGON branch April 10, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants