Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): set setting case insensitive #15199

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix(query): set setting case insensitive #15199

merged 1 commit into from
Apr 9, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Apr 9, 2024 •
edited

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

E.g.

SET GLOBAL DATA_RETENTION_TIME_IN_DAYS=0; -- Need work

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Apr 9, 2024
@TCeason
fix(query): set setting case insensitive
e6a3f43 
E.g.

```sql
SET GLOBAL data_retention_time_in_days=0; -- Need work
```
@BohuTANG BohuTANG requested a review from zhang2014 April 9, 2024 13:33
@BohuTANG BohuTANG merged commit c2e3ee6 into datafuselabs:main Apr 9, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: SET GLOBAL DATA_RETENTION_TIME_IN_DAYS = 0; Unknown variable: "DATA_RETENTION_TIME_IN_DAYS"
3 participants
@TCeason @zhang2014 @BohuTANG