refactor: introduce UninitTenant and TIdentRaw
#15207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
43-tident-value
branch
7 times, most recently
from
dcf3105
to
c639c6d
Compare
BohuTANG
approved these changes
Apr 11, 2024
drmingdrmer
force-pushed
the
43-tident-value
branch
from
c639c6d
to
bdd2718
Compare
`Tenant` is a meta-service key component representing a tenant, with a embedded per-tenant config. `UninitTenant` is a shadow of `TIdent` but without config thus it can not be used as a key. `UninitTenant` can be initialized to build a `Tenant` for use as a meta-service key. Correspondingly, this commit introduce `TIdentRaw` as an uninitialized version of `TIdent`. `TIdentRaw` does not cantain per-tenant config and is only used inside meta-service values(not keys), which could be `serde`. Other changes: Populate usage of `Tennat` to `Catalog` implementation.
drmingdrmer
force-pushed
the
43-tident-value
branch
from
52ad422
to
6e1d76d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: introduce
UninitTenantandTIdentRawTenantis a meta-service key component representing a tenant,with a embedded per-tenant config.
UninitTenantis a shadow ofTIdentbut without config thus it cannot be used as a key.
UninitTenantcan be initialized to build aTenantfor use as ameta-service key.
Correspondingly, this commit introduce
TIdentRawas an uninitializedversion of
TIdent.TIdentRawdoes not cantain per-tenant config and is only used insidemeta-service values(not keys), which could be
serde.Other changes:
Populate usage of
TennattoCatalogimplementation.Tests
Type of change
Related Issues
This change is