Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): fix nullable array domain #15224

Merged
merged 1 commit into from
Apr 12, 2024
Merged

chore(query): fix nullable array domain #15224

merged 1 commit into from
Apr 12, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Apr 12, 2024 •
edited by drmingdrmer

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix nullable array domain

The previous domain of nullable<array> will generate stats of null_count = 0.
This is incorrect.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li requested a review from b41sh April 12, 2024 03:05
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 12, 2024
@BohuTANG BohuTANG added the ci-cloud Build docker image for cloud test label Apr 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-15224-b66ad19

note: this image tag is only available for internal use,
please check the internal doc for more details.

@BohuTANG BohuTANG merged commit 9b1887a into datafuselabs:main Apr 12, 2024
86 checks passed
@sundy-li sundy-li mentioned this pull request Apr 24, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

@dantengsky dantengsky Awaiting requested review from dantengsky

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: no overload satisfies cosine_distance(Array(Float32 NULL) NULL, Array(Float32))
3 participants
@sundy-li @b41sh @BohuTANG