fix: fix map get return double nested nullable #15230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
for this query:
The
tags[az]
will callmap#get
with input data typeMapType<GenericType<0>, GenericType<1>>
and return data typeNullableType<GenericType<1>>
, however, ifGenericType<1>
is already a nullable type, this will returnNullable<Nullable<XXX>>
.When this return type pass to
to_int32
, thetry_downcast_column().unwrap()
will failed.This PR add a new
get
function for map get that catch nullable value in map first.Tests
Type of change
This change is