Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add azblob stage support #15234

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Add azblob stage support #15234

wants to merge 1 commit into from

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 15, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR adds azblob stage support.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Apr 15, 2024
Copy link

what-the-diff bot commented Apr 15, 2024

PR Summary

  • Added support for Azure Blob Storage in storage configuration
    Enriched the storage configuration options by adding Azure Blob Storage support. This is implemented through the addition of Storage::Azblob in the general storage configuration and a related StorageAzblobConfig in the protobuf configuration implementation.

  • Added test configuration and cases for Azure Blob storage integration
    To ensure correct function and alignment with other storage options, added a new test suite specifically for Azure Blob Storage configurations. This includes a newly introduced test configuration v087_azblob_config and a dedicated test case test_decode_v87_azblob_config.

  • Modified location binding for Azure Blob Storage integration
    As part of adapting the Azure Blob Storage integration, we have revamped certain functions for URI location parsing (parse_uri_location) and param parsing (parse_azblob_params), enhancing how parameters are interpreted and ensuring consistent behaviour.

  • Updated SQL statements for Stage creation and deletion for Azure Blob Storage
    Added the relevant SQL DDL statements to create or replace and drop stages for Azure Blob Storage configurations in our testing. This assures that the operations performed on this storage option are aligned with the usual operations for other storage types.

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Xuanwo)

@BohuTANG
Copy link
Member

It seems this PR breaking something, many tests failed.

@BohuTANG BohuTANG marked this pull request as draft June 2, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create a stage on azure blob storage.
4 participants