refactor: Introduce generic parameter N to TIdent
#15271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
drmingdrmer
force-pushed
the
51-t-ident-generic
branch
from
cc435bd
to
b334582
Compare
drmingdrmer
changed the title
N to TIdent
github-actions
bot
added
the
pr-refactor
Added a generic parameter `N` to the `TIdent` type, which defaults to `String`. This allows for flexibility in defining `TIdent` with various types, such as `u64`, accommodating different key identification requirements.
drmingdrmer
force-pushed
the
51-t-ident-generic
branch
from
b334582
to
df9ce3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
chore: move KeyCodec to separate file
refactor: Introduce generic parameter
NtoTIdentAdded a generic parameter
Nto theTIdenttype, which defaults toString. This allows for flexibility in definingTIdentwith varioustypes, such as
u64, accommodating different key identificationrequirements.
Tests
Type of change
Related Issues
This change is