Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix delete from subquery and one more condition bug #15279

Merged
merged 6 commits into from
Apr 20, 2024

Conversation

lichuang
Copy link
Collaborator

@lichuang lichuang commented Apr 19, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

when remove from subquery condition, projection only consider subquery columns, so when query condition contains another condition but not subquery will fail, such as:

delete from test where (a) in(select a from test_tmp where b in ('update', 'delete')) and c in ('table38426');

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Apr 19, 2024
@BohuTANG BohuTANG merged commit 1544347 into datafuselabs:main Apr 20, 2024
72 checks passed
@TCeason TCeason mentioned this pull request Apr 22, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: delete from subquery error
3 participants