refactor: define ShareConsumer with TIdent
#15280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
53-share-consumer
branch
from
a3ac1a7
to
3f8313a
Compare
Remove the logic of not embedding `share_id` if it is 0. Because `share_id` is always non-zero.
drmingdrmer
force-pushed
the
53-share-consumer
branch
from
3f8313a
to
2755299
Compare
BohuTANG
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: define
ShareConsumerwithTIdentRemove the logic of not embedding
share_idif it is 0.Because
share_idis always non-zero.chore: Use ShareConsumer::new() for construction
Tests
Type of change
Related Issues
This change is