Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): refine set sql_dialect error message #15282

Merged

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Apr 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Refine set sql_dialect error message: set sql_dialect = experimental -> set sql_dialect = 'experimental'.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Change error message, no need test.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): change error message

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 20, 2024
@Dousir9 Dousir9 marked this pull request as ready for review April 20, 2024 15:07
@BohuTANG BohuTANG merged commit 988d0f3 into datafuselabs:main Apr 21, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants