Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): fix decimal op loss precision #15313

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix(query): fix decimal op loss precision #15313

merged 2 commits into from
Apr 23, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Apr 23, 2024 •
edited by drmingdrmer

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix decimal op loss precision

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Apr 23, 2024
@BohuTANG BohuTANG merged commit 541b8e9 into datafuselabs:main Apr 23, 2024
72 checks passed
yufan022 pushed a commit to yufan022/databend that referenced this pull request Apr 30, 2024
@sundy-li @yufan022
fix(query): fix decimal op loss precision (datafuselabs#15313)
3d8d72f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

@b41sh b41sh Awaiting requested review from b41sh

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: minusing sum decimal precision is wrong
2 participants
@sundy-li @BohuTANG