Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect overlap checking (replace into) #15315

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Apr 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

During overlap detection while executing replace-into stmt, if column being checked has no range index, we should assume there are overlaps.

before this PR:

create or replace table t( c1 bool);
replace into t on(c1) values(false);
replace into t on(c1) values(false);
select count(*) from t; -- return 2, which is incorrect

with this PR

create or replace table t( c1 bool);
replace into t on(c1) values(false);
replace into t on(c1) values(false);
select count(*) from t; -- return 1, which is expected

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

should return false if column being checked has no range index.
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Apr 23, 2024
@dantengsky dantengsky marked this pull request as ready for review April 23, 2024 16:58
@dantengsky dantengsky requested a review from zhyass April 23, 2024 16:58
Copy link
Member

@zhyass zhyass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhyass zhyass added this pull request to the merge queue Apr 24, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Apr 24, 2024
@BohuTANG BohuTANG merged commit 9c43f7c into datafuselabs:main Apr 24, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: replace into when on fields have bool type will insert a new record
3 participants