Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce enterprise storage quota feature #15338

Merged
merged 8 commits into from
Apr 28, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 25, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Part of #15306

This PR just introduce the feature flag and no real logic been implemented.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from ZhiHanZ April 25, 2024 13:19
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Apr 25, 2024
@Xuanwo Xuanwo requested a review from everpcpc April 25, 2024 13:19
@Xuanwo Xuanwo enabled auto-merge April 25, 2024 13:43
@Xuanwo Xuanwo disabled auto-merge April 25, 2024 14:31
@Xuanwo Xuanwo marked this pull request as draft April 25, 2024 14:31
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 25, 2024

This PR should wait for #15336

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from zhang2014 April 28, 2024 08:25
@Xuanwo Xuanwo marked this pull request as ready for review April 28, 2024 08:25
Copy link
Collaborator

@ZhiHanZ ZhiHanZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit 1a455af into datafuselabs:main Apr 28, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants