Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve install-snapshot performance #15345

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Apr 26, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: improve install-snapshot performance

Move the IO into a separate thread and use std::io instead of tokio::io.

Using tokio::io and a default buf size of 8KB, reading 1.4G snapshot takes 60 seconds.
Using std::io and a 16MB buffer, reading 1.4G snapshot takes 7 seconds.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Apr 26, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review April 26, 2024 06:53
Move the IO into a separate thread and use `std::io` instead of `tokio::io`.
@BohuTANG BohuTANG merged commit 0b23dcb into datafuselabs:main Apr 26, 2024
72 checks passed
@drmingdrmer drmingdrmer deleted the 33-openraft-096 branch April 26, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants