Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enhance runtime filter log #15350

Merged
merged 1 commit into from
Apr 27, 2024
Merged

chore: enhance runtime filter log #15350

merged 1 commit into from
Apr 27, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Apr 27, 2024 •
edited by drmingdrmer

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 27, 2024
dantengsky
dantengsky previously approved these changes Apr 27, 2024
View reviewed changes
@dantengsky dantengsky added this pull request to the merge queue Apr 27, 2024
@dantengsky dantengsky removed this pull request from the merge queue due to a manual request Apr 27, 2024
@xudong963 xudong963 added this pull request to the merge queue Apr 27, 2024
@dantengsky dantengsky dismissed their stale review April 27, 2024 10:48

sorry, there is a little concern about the logging

@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Apr 27, 2024
@BohuTANG BohuTANG merged commit fb31f82 into datafuselabs:main Apr 27, 2024
75 checks passed
@xudong963 xudong963 deleted the enhance_log branch April 27, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantengsky dantengsky dantengsky approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xudong963 @dantengsky @BohuTANG