Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move snapshot building io to other task. #15351

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Apr 28, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: move snapshot building io to other task.

Add short sleep to avoid starving sled IO.

This commit is meant to address the issue when building a snapshot,
other IO such as appending log to sled db is delay significantly.

Remove several unnecessary INFO level log.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Apr 28, 2024
Add short sleep to avoid starving sled IO.

This commit is meant to address the issue when building a snapshot,
other IO such as appending log to sled db is delay significantly.

Remove several unnecessary INFO level log.
@drmingdrmer drmingdrmer marked this pull request as ready for review April 28, 2024 02:19
@drmingdrmer drmingdrmer merged commit d82e7b6 into datafuselabs:main Apr 28, 2024
78 checks passed
@drmingdrmer drmingdrmer deleted the 33-openraft-096 branch April 28, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant