Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove stage use stream to avoid OOM. #15378

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Apr 30, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

remove stage use stream instead of load all paths into one Vec to avoid OOM.

00_0004_copy_with_max_files.sh is changed too, no longer rely on the order of list of backends . cc @Xuanwo

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Apr 30, 2024
@youngsofun youngsofun marked this pull request as draft April 30, 2024 04:53
@youngsofun youngsofun force-pushed the stage2 branch 3 times, most recently from c06ff0c to d9622be Compare April 30, 2024 06:36
@youngsofun youngsofun requested a review from Xuanwo April 30, 2024 07:12
@youngsofun youngsofun marked this pull request as ready for review April 30, 2024 07:14
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. The only question to me is how can we test this PR?

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sundy-li sundy-li added this pull request to the merge queue Apr 30, 2024
Merged via the queue into datafuselabs:main with commit aa7960a Apr 30, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants