Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust row count assertion in table compaction #15380

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Apr 30, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Correct the assertion to check that the row count remains unchanged during table compaction, instead of comparing it(new snapshot) to the pre-compaction snapshot. This change accounts for scenarios where the new snapshot results from a combination of compaction and insertion, potentially increasing the total number of rows.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - only a defensive runtime assertion changed

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): only a defensive runtime assertion changed

This change is Reviewable

Correct the assertion to check that the row count remains unchanged
during table compaction, instead of comparing it(new snapshot) to the
pre-compaction snapshot. This change accounts for scenarios where the
new snapshot results from a combination of compaction and insertion,
potentially increasing the total number of rows.
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Apr 30, 2024
@dantengsky dantengsky changed the title fix: adjust row count assertion in table compaction chore: adjust row count assertion in table compaction Apr 30, 2024
@dantengsky dantengsky removed the pr-bugfix this PR patches a bug in codebase label Apr 30, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 30, 2024
@dantengsky dantengsky marked this pull request as ready for review April 30, 2024 06:42
@dantengsky dantengsky added this pull request to the merge queue Apr 30, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Apr 30, 2024
@BohuTANG BohuTANG merged commit be942d3 into datafuselabs:main Apr 30, 2024
82 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants