Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove get_table_name_by_id() #15389

Merged
merged 1 commit into from
May 1, 2024
Merged

refactor: remove get_table_name_by_id() #15389

merged 1 commit into from
May 1, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented May 1, 2024 •
edited

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: remove get_table_name_by_id()

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label May 1, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review May 1, 2024 13:15
@drmingdrmer drmingdrmer requested a review from TCeason May 1, 2024 13:15
TCeason
TCeason reviewed May 1, 2024
View reviewed changes
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now only validate_grant_object_exists use get_table_name_by_id and get_db_name_by_id. So can also remove get_db_name_by_id.

BTW If remove them, need also modify validate_grant_object_exists

@drmingdrmer drmingdrmer merged commit 3f8e36c into datafuselabs:main May 1, 2024
78 checks passed
@drmingdrmer drmingdrmer deleted the 67-remove-get-table-name-by-id branch May 1, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCeason TCeason TCeason left review comments

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drmingdrmer @TCeason