Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): support parse create dictionary stmt #16137

Merged
merged 5 commits into from
Jul 28, 2024
Merged

feat(query): support parse create dictionary stmt #16137

merged 5 commits into from
Jul 28, 2024

Conversation

Winnie-Hong0927
Copy link
Contributor

@Winnie-Hong0927 Winnie-Hong0927 commented Jul 27, 2024 •
edited by b41sh
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

support parse create/drop/show dictionary stmt

part of #15901

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 27, 2024
@b41sh b41sh self-requested a review July 27, 2024 04:38
@b41sh b41sh marked this pull request as draft July 27, 2024 04:40
b41sh
b41sh reviewed Jul 27, 2024
View reviewed changes
src/query/ast/src/ast/format/ast_format.rs Outdated Show resolved Hide resolved
src/query/ast/src/ast/format/ast_format.rs Outdated Show resolved Hide resolved
@b41sh b41sh marked this pull request as ready for review July 27, 2024 06:44
@b41sh b41sh requested a review from sundy-li July 27, 2024 06:44
@BohuTANG
Copy link
Member

@Winnie-Hong0927

Thanks for the contribution!
Can you open a new issue for tracking the dictonary feature? For example: #16135

@b41sh
Copy link
Member

b41sh commented Jul 27, 2024

@Winnie-Hong0927

Thanks for the contribution! Can you open a new issue for tracking the dictonary feature? For example: #16135

we already have a tracking issue #15901

b41sh
b41sh approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution @Winnie-Hong0927

@BohuTANG BohuTANG merged commit f19cfa6 into datafuselabs:main Jul 28, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Winnie-Hong0927 @BohuTANG @b41sh @sundy-li