Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Install arm64 version of libssl and zlib1g #3371

Merged
merged 1 commit into from Dec 11, 2021

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 10, 2021

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

This PR is a follow-up of #3353, addressed extra problems.

Explanation

After #3353 get merged, our contributors report more problems around aarch64 cross-build-related issues.

In fact, it's a long-existing issue from rust-embedded/cross community: cross-rs/cross#229.

cross uses self-compiled OpenSSL to provide SSL support, and this resulted in a lot issues so the community choose to remove the entire SSL support in PR: cross-rs/cross#322. But we really need OpenSSL! So we have to add the removed shells back as described in cross-rs/cross#229 (comment).

Let's come back to the root cause: what happened to the OpenSSL (and other) libs? Why we can't cross-compile aarch64? It's a knowledge gap between rust and ubuntu community:

We didn't install the aarch64 versions lib, so pkg-config can't find them.

It's simple to solve the problem:

First of all, add arm64 architecture support:

dpkg --add-architecture arm64

Then, install the arm64 version of lib, take libssl and zlib1g for example:

apt-get install --assume-yes libssl-dev libssl-dev:arm64 zlib1g-dev zlib1g-dev:arm64

No need to other tricks, the ubuntu maintainers already fixed them, Thanks!

For reference:

Changelog

  • Build/Testing/CI

Signed-off-by: Xuanwo <github@xuanwo.io>
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added pr-build this PR changes build/testing/ci steps need-review labels Dec 10, 2021
@vercel
Copy link

vercel bot commented Dec 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/A4aWHPBdqhcvXQAau8MUTJ47E7wr
✅ Preview: Canceled

@codecov-commenter
Copy link

Codecov Report

Merging #3371 (4d9cfc5) into main (5540a6d) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3371   +/-   ##
=====================================
- Coverage     61%     61%   -1%     
=====================================
  Files        606     606           
  Lines      33771   33771           
=====================================
- Hits       20859   20841   -18     
- Misses     12912   12930   +18     
Impacted Files Coverage Δ
common/clickhouse-srv/src/connection.rs 81% <0%> (-17%) ⬇️
common/base/src/progress.rs 69% <0%> (-16%) ⬇️
metasrv/src/meta_service/raftmeta.rs 43% <0%> (-3%) ⬇️
common/meta/sled-store/src/sled_tree.rs 91% <0%> (-1%) ⬇️
common/management/src/cluster/cluster_mgr.rs 79% <0%> (+<1%) ⬆️
...pelines/transforms/transform_aggregator_partial.rs 87% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5540a6d...4d9cfc5. Read the comment docs.

@ZhiHanZ ZhiHanZ marked this pull request as ready for review December 11, 2021 07:05
@ZhiHanZ
Copy link
Collaborator

ZhiHanZ commented Dec 11, 2021

\lgtm

@ZhiHanZ ZhiHanZ self-requested a review December 11, 2021 07:08
@databend-bot
Copy link
Member

Wait for another reviewer approval

@BohuTANG BohuTANG merged commit cea40dc into datafuselabs:main Dec 11, 2021
@Xuanwo Xuanwo deleted the cleanup-build-tool branch December 11, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants