-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wait_tcp.py to python3 #3701
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
1 similar comment
Thanks for the contribution! Please review the labels and make any necessary changes. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/2dqzHWz9EUcrJV65LHDCVcZPJL5R |
@@ -43,7 +43,7 @@ if [ "$mode" == "boot" ]; then | |||
--log-dir ./_logs1 \ | |||
--raft-api-port 28103 \ | |||
& | |||
python scripts/ci/wait_tcp.py --timeout 5 --port 9191 | |||
python3 scripts/ci/wait_tcp.py --timeout 5 --port 9191 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the python3
command available in the major os environment like Darwin, ubuntu, fedora? q.q
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubuntu and Darwin I think the answer yes
And I saw python3
command in dev_setup
https://github.com/datafuselabs/databend/blob/main/scripts/setup/dev_setup.sh#L298
or maybe we can make the command from setup_dev
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, we can take the python commands the same among the script files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
users env
may have both python and python3
we can get the python env command in setup ln the python3 command.
/lgtm |
Codecov Report
@@ Coverage Diff @@
## main #3701 +/- ##
=====================================
- Coverage 60% 60% -1%
=====================================
Files 706 706
Lines 37901 37901
=====================================
- Hits 22806 22787 -19
- Misses 15095 15114 +19
Continue to review full report at Codecov.
|
@yihong0618 Thank you! |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
Changelog
Related Issues
As discussed in #3689 port the
wait_tcp.py
to Python3.And use
context manager
to make sure the sock close.