Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metasrv] refine grpc #3717

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Conversation

ariesdevil
Copy link
Member

@ariesdevil ariesdevil commented Dec 31, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Changelog

  • Improvement

Related Issues

None

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

2 similar comments
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/DeoeX4ZjwU8sSzbXScqsAvKkMrxH
✅ Preview: Canceled

[Deployment for 87c4ff4 canceled]

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #3717 (87c4ff4) into main (5f8947c) will decrease coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3717   +/-   ##
=====================================
- Coverage     60%     59%   -1%     
=====================================
  Files        705     705           
  Lines      37925   37921    -4     
=====================================
- Hits       22766   22752   -14     
- Misses     15159   15169   +10     
Impacted Files Coverage Δ
common/meta/grpc/src/grpc_client.rs 0% <ø> (ø)
common/meta/grpc/src/grpc_client_conf.rs 0% <ø> (ø)
metasrv/src/executor/action_handler.rs 91% <ø> (ø)
metasrv/src/executor/meta_handlers.rs 81% <ø> (ø)
query/src/common/meta/meta_client.rs 26% <ø> (ø)
query/src/configs/config_meta.rs 87% <ø> (ø)
metasrv/src/api/grpc/grpc_service.rs 92% <100%> (-1%) ⬇️
metasrv/src/meta_service/meta_service_impl.rs 92% <100%> (+<1%) ⬆️
query/src/common/mod.rs 70% <0%> (-15%) ⬇️
...pelines/transforms/transform_aggregator_partial.rs 86% <0%> (-2%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3328a38...87c4ff4. Read the comment docs.

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... appreciating these rational crate path in this patch!

common/meta/grpc/Cargo.toml Outdated Show resolved Hide resolved
use crate::MetaGrpcClient;

#[async_trait::async_trait]
#[tonic::async_trait]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it switched from async_trait to tonic?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tonic::async_trait is just re-pub async_trait::async_trait, using tonic reduce a dep crate:)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense 🤔

@databend-bot
Copy link
Member

Wait for another reviewer approval

@ariesdevil ariesdevil merged commit 9a9351d into datafuselabs:main Dec 31, 2021
@ariesdevil ariesdevil deleted the r-refine-grpc branch December 31, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants