-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metasrv] refine grpc #3717
[metasrv] refine grpc #3717
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
2 similar comments
Thanks for the contribution! Please review the labels and make any necessary changes. |
Thanks for the contribution! Please review the labels and make any necessary changes. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/DeoeX4ZjwU8sSzbXScqsAvKkMrxH [Deployment for 87c4ff4 canceled] |
Codecov Report
@@ Coverage Diff @@
## main #3717 +/- ##
=====================================
- Coverage 60% 59% -1%
=====================================
Files 705 705
Lines 37925 37921 -4
=====================================
- Hits 22766 22752 -14
- Misses 15159 15169 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... appreciating these rational crate path in this patch!
use crate::MetaGrpcClient; | ||
|
||
#[async_trait::async_trait] | ||
#[tonic::async_trait] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it switched from async_trait
to tonic
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tonic::async_trait
is just re-pub async_trait::async_trait
, using tonic
reduce a dep crate:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense 🤔
Wait for another reviewer approval |
91c32f8
to
87c4ff4
Compare
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Changelog
Related Issues
None
Test Plan
Unit Tests
Stateless Tests