Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Debug trait for Column #3965

Merged
merged 1 commit into from Jan 24, 2022

Conversation

Veeupup
Copy link
Collaborator

@Veeupup Veeupup commented Jan 24, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

add Debug impl for Column for better debugging, just like below:

PrimitiveColumn          typeid: UInt8   len: 2  data: [1, 2]
PrimitiveColumn          typeid: Float32         len: 2  data: [1, 2]
NullColumn       typeid: Null    len: 3  data: [NULL...]
BooleanColumn    typeid: Boolean         len: 3  data: [true, false, true]
StringColumn     typeid: String  len: 2  data: [aaa, bbb]
NullableColumn   typeid: Int32   len: 3  data: [NULL, NULL, 12]
ArrayColumn      typeid: Array   len: 3  data: [[test], [data, bend], [hello, world, NULL]]
StructColumn     typeid: Struct  len: 3  data: [[18869, 1], [18948, 2], [1, 3]]

Changelog

  • Improvement

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: Veeupup <code@tanweime.com>
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

3 similar comments
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Jan 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

databend – ./

🔍 Inspect: https://vercel.com/flaneur2021/databend/Bbf8MfdZr1YMPsDetGqPiwcXbof9
✅ Preview: https://databend-git-fork-veeupup-adddebugcolumn-flaneur2021.vercel.app

@codecov-commenter
Copy link

Codecov Report

Merging #3965 (9630eb5) into datavalues-dev (4c6325b) will decrease coverage by 0%.
The diff coverage is 2%.

Impacted file tree graph

@@               Coverage Diff               @@
##           datavalues-dev   #3965    +/-   ##
===============================================
- Coverage              57%     57%    -1%     
===============================================
  Files                 809     811     +2     
  Lines               43663   43815   +152     
===============================================
+ Hits                24999   25051    +52     
- Misses              18664   18764   +100     
Impacted Files Coverage Δ
common/datavalues2/src/columns/array/mod.rs 24% <0%> (-3%) ⬇️
common/datavalues2/src/columns/column.rs 40% <0%> (-12%) ⬇️
common/datavalues2/src/columns/null/mod.rs 0% <0%> (ø)
common/datavalues2/src/columns/nullable/mod.rs 68% <0%> (-6%) ⬇️
common/datavalues2/src/columns/string/mod.rs 66% <0%> (-3%) ⬇️
common/datavalues2/src/columns/struct_/mod.rs 20% <0%> (-3%) ⬇️
common/datavalues2/src/data_value.rs 20% <0%> (+1%) ⬆️
common/datavalues2/src/columns/boolean/mod.rs 67% <16%> (-5%) ⬇️
common/datavalues2/src/columns/primitive/mod.rs 61% <16%> (-1%) ⬇️
...mon/functions/src/scalars/strings/string2number.rs 20% <0%> (-40%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6325b...9630eb5. Read the comment docs.

@databend-bot
Copy link
Member

Wait for another reviewer approval

@sundy-li sundy-li merged commit 2a550ab into datafuselabs:datavalues-dev Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants