Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TENANT-4054: Add tenant empty check #4057

Merged
merged 4 commits into from Feb 6, 2022

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Feb 5, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR:

  1. Add tenant empty check to KVApi and MetaApi, make sure the tenant not empty to metasrv
  2. Make the tests more simple

Changelog

  • Improvement

Related Issues

Fixes #4054

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Feb 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/3wi7HrjP91Vh4yKgGsT8YFkpZCPH
✅ Preview: Canceled

[Deployment for 2650e4f canceled]

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2022

Codecov Report

Merging #4057 (2650e4f) into main (c340c45) will increase coverage by 0%.
The diff coverage is 82%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4057   +/-   ##
=====================================
  Coverage     57%     57%           
=====================================
  Files        825     825           
  Lines      43625   43657   +32     
=====================================
+ Hits       24935   24979   +44     
+ Misses     18690   18678   -12     
Impacted Files Coverage Δ
query/src/users/role_mgr.rs 85% <ø> (ø)
query/src/users/user_setting.rs 0% <ø> (ø)
common/management/src/role/role_mgr.rs 77% <60%> (-1%) ⬇️
common/management/src/setting/setting_mgr.rs 94% <60%> (-2%) ⬇️
common/management/src/stage/stage_mgr.rs 92% <60%> (-2%) ⬇️
common/management/src/udf/udf_mgr.rs 87% <60%> (-1%) ⬇️
common/management/src/user/user_mgr.rs 94% <60%> (-1%) ⬇️
common/management/src/cluster/cluster_mgr.rs 77% <75%> (-3%) ⬇️
query/src/catalogs/impls/database_catalog.rs 78% <86%> (+1%) ⬆️
query/src/clusters/cluster.rs 40% <100%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c340c45...2650e4f. Read the comment docs.

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:DDD

@drmingdrmer
Copy link
Member

/lgtm

@databend-bot
Copy link
Member

Wait for another reviewer approval

@databend-bot
Copy link
Member

CI Passed
Reviewers Approved
Let's Merge
Thank you for the PR @BohuTANG

@databend-bot databend-bot merged commit 4951907 into datafuselabs:main Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Denied if tenant is empty when get meta client
5 participants