Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-4259: Change to atomic for dal context metrics #4262

Merged
merged 4 commits into from
Feb 26, 2022

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Feb 26, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR:

  1. Change the DalMetrics update from RwLock to Atomic operation
  2. Remove un-used metrics: scan_seek_cost_ms and scan_seeks
  3. Add common/contexts for the common used context

Changelog

  • Improvement
  • Performance Improvement

Related Issues

Fixes #4259

Test Plan

Unit Tests

Stateless Tests

@vercel
Copy link

vercel bot commented Feb 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/8pWgoEKFtQLFwZZ7TiY7VYMrWo6R
✅ Preview: Canceled

[Deployment for 7e47ca6 canceled]

@BohuTANG BohuTANG changed the title ISSUE-4269: Change to atomic for dal context metrics ISSUE-4259: Change to atomic for dal context metrics Feb 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change DalContext Arc<RwLock<DalMetrics>> to atomic operation
2 participants