Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add benchmark solution with hyperfine #4545

Merged
merged 5 commits into from Mar 23, 2022
Merged

*: add benchmark solution with hyperfine #4545

merged 5 commits into from Mar 23, 2022

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Mar 23, 2022 •
edited

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

remove databend-benchamrk and old perf tools

add benchmark solution with hyperfine

Changelog

  • Build/Testing/CI
  • Documentation

Related Issues

Related #4324

Test Plan

Unit Tests

Stateless Tests

@PsiACE PsiACE requested a review from BohuTANG as a code owner March 23, 2022 03:26
@vercel
Copy link

vercel bot commented Mar 23, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/3yafoyktDzBMFNfKPjnM95t9gRUV
✅ Preview: https://databend-git-fork-psiace-remove-benchmark-databend.vercel.app

@PsiACE PsiACE requested review from Xuanwo and ZhiHanZ March 23, 2022 03:26
@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-build this PR changes build/testing/ci steps pr-doc-fix labels Mar 23, 2022
@PsiACE PsiACE changed the title docs(faq/benchmark): add benchmark solution with hyperfine *: add benchmark solution with hyperfine Mar 23, 2022
@PsiACE PsiACE marked this pull request as draft March 23, 2022 04:06
ZhiHanZ
ZhiHanZ approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@ZhiHanZ ZhiHanZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PsiACE PsiACE marked this pull request as ready for review March 23, 2022 08:15
@BohuTANG BohuTANG merged commit 4adbfa4 into datafuselabs:main Mar 23, 2022
@PsiACE PsiACE deleted the remove-benchmark branch March 23, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li left review comments

@ZhiHanZ ZhiHanZ ZhiHanZ approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

Assignees
No one assigned
Labels
need-review pr-build this PR changes build/testing/ci steps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PsiACE @sundy-li @ZhiHanZ @BohuTANG @databend-bot