Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): Add git latest tag to the build version #4551

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Mar 23, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Add git latest tag to the build version.

Old:

mysql> select version();
+----------------------------------------------------------------------------------------+
| version()                                                                              |
+----------------------------------------------------------------------------------------+
| DatabendQuery v-0.1.0-213b1f7-simd(1.61.0-nightly-2022-03-19T01:39:28.774417429+00:00) |
+----------------------------------------------------------------------------------------+

Now:

+-------------------------------------------------------------------------------------------------------+
| version()                                                                                             |
+-------------------------------------------------------------------------------------------------------+
| DatabendQuery v0.6.99-nightly-c8fda7f-simd(rust-1.61.0-nightly-2022-03-23T08:28:10.740108668+00:00) |
+-------------------------------------------------------------------------------------------------------+

Changelog

  • Improvement

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

@vercel
Copy link

vercel bot commented Mar 23, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/CevweqaDDeNNSNopubFEjAx5Bgjk
✅ Preview: Canceled

[Deployment for 7fb87d9 canceled]

@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@Xuanwo
Copy link
Member

Xuanwo commented Mar 23, 2022

v-v0.6.99-nightly seems buggy

@BohuTANG
Copy link
Member Author

v-v0.6.99-nightly seems buggy

genver VERGEN_GIT_SEMVER foramt is v-{git-tag}, and the git-tag name is v0.6.99-nightly.
It's not bug here :D

@BohuTANG
Copy link
Member Author

v-v0.6.99-nightly seems buggy

genver VERGEN_GIT_SEMVER foramt is v-{git-tag}, and the git-tag name is v0.6.99-nightly. It's not bug here :D

Oh, I see, you are right.

@BohuTANG BohuTANG merged commit 0de22d7 into databendlabs:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants