-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(function): Support Semi-structured function GET/GET_IGNORE_CASE/GET_PATH #4684
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/6L2CxR4bqkHs7FoJ2MciC3NWeUyb |
Thanks for the contribution! Please review the labels and make any necessary changes. |
@mergify update |
✅ Branch has been successfully updatedHey, I reacted but my real name is @Mergifyio |
|
done. |
Thanks for the contribution! Please review the labels and make any necessary changes. |
Thanks for the contribution! Please review the labels and make any necessary changes. |
continue; | ||
} | ||
for v in column.iter() { | ||
let mut found_value = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will found_value
defaults to false make this more simple?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value of found_value
is not simpler to set as false, because the lookup is recursive. If we can find a value we need to set it to true, otherwise we set it to false. If the default value is false, the following set found_value = false
can't be omitted, but need to add some code to set found_value = true
.
|
this is caused by another bug, I will fix it. |
Conflicts that must be resolved :D |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Support
GET
functionSupport
GET_IGNORE_CASE
functionSupport
GET_PATH
functionChangelog
Related Issues
Fixes #4665
Test Plan
Unit Tests
Stateless Tests