feature(base): supports memory usage limits. #7290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Xuanwo
reviewed
Aug 25, 2022
| builder | ||
| .enable_all() | ||
| .on_thread_stop(rt_tracker.on_stop_thread()) | ||
| .on_thread_start(rt_tracker.on_start_thread()); | ||
| .on_thread_stop(|| { ThreadTracker::destroy(); }) |
There was a problem hiding this comment.
For better understanding, how about:
.on_thread_start(xxx)
.on_thread_stop(xxx)| @@ -0,0 +1,216 @@ | |||
| // Copyright 2021 Datafuse Labs. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2021 Datafuse Labs. | |
| // Copyright 2022 Datafuse Labs. |
|
|
||
| #[inline] | ||
| pub fn realloc_memory(old_size: i64, new_size: i64) { | ||
| let addition = new_size - old_size; |
There was a problem hiding this comment.
What's different between new_size > old_size?
| self.memory_usage.load(Ordering::Relaxed) | ||
| + UNTRACKED_MEMORY_LIMIT * self.total_thread_size.load(Ordering::Relaxed) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we have a unit test for this mod?
43 tasks
|
Feel free to open it again ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
feature(base): supports memory usage limits.
fixes #7271