Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta-service): remove redundant ActionHandler; move logic into MetaServiceImpl #7555

Merged
merged 2 commits into from Sep 10, 2022

Conversation

drmingdrmer
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

refactor(meta-service): remove redundant ActionHandler; move logic into MetaServiceImpl
refactor(meta-service): add MetaGrpcReq, as a replacement of MetaGrpcReadReq and MetaGrpcWriteReq.

There is no need to distinguish read/write at the request level.

Changelog

Related Issues

…ReadReq and MetaGrpcWriteReq.

There is no need to distinguish read/write at the request level.
@vercel
Copy link

vercel bot commented Sep 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Sep 9, 2022 at 2:45PM (UTC)

@drmingdrmer drmingdrmer marked this pull request as ready for review September 9, 2022 14:45
@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 9, 2022
@drmingdrmer drmingdrmer merged commit 01c592f into datafuselabs:main Sep 10, 2022
@drmingdrmer drmingdrmer deleted the 8-grpc-req branch September 12, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant