Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add XOR bloom filter #7860

Merged
merged 9 commits into from
Sep 24, 2022
Merged

feat: add XOR bloom filter #7860

merged 9 commits into from
Sep 24, 2022

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Sep 24, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Introduce a new bloom trait
  • Use XOR instead of bloom filter

Test result(bitmap encode size / raw data size):

u64: 
xor bitmap encode:1230069 bytes, raw:8000000 bytes, ratio:0.15375863

bool:
xor bitmap encode:61 bytes, raw:1000000 bytes, ratio:0.000061

string:
xor bitmap encode:123067 bytes, raw:3000000 bytes, ratio:0.041022334

100000 records of the same key:
xor bitmap encode: 61 bytes, raw:3000000 bytes, ratio:0.000020333333

Part of #7748

@vercel
Copy link

vercel bot commented Sep 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Sep 24, 2022 at 0:34AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Sep 24, 2022
@BohuTANG BohuTANG changed the title feat: try XOR bloom filter feat: add XOR bloom filter Sep 24, 2022
@BohuTANG BohuTANG marked this pull request as ready for review September 24, 2022 12:19
Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's roll

@BohuTANG BohuTANG merged commit 7847147 into databendlabs:main Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants