Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(meta): fix slow-request timing #7873

Merged
merged 2 commits into from Sep 25, 2022

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Sep 25, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

chore(meta): fix slow-request timing

The start time should be set after a req is received, not before.
Otherwise the elapsed time includes the time spent on waiting for a req.

chore(meta): log time spent when applying a command to state machine

The start time should be set after a req is received, not before.
Otherwise the elapsed time includes the time spent on waiting for a req.
@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 25, 2022
@vercel
Copy link

vercel bot commented Sep 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Sep 25, 2022 at 5:00AM (UTC)

@drmingdrmer drmingdrmer marked this pull request as ready for review September 25, 2022 05:01
@BohuTANG BohuTANG merged commit f12f1bd into datafuselabs:main Sep 25, 2022
@drmingdrmer drmingdrmer deleted the 01-log-time branch October 8, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: MetaGrpcClient slow request Upsert
2 participants