Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: TypeDeserializer get rid of FormatSetting. #8950

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Nov 24, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

part1 of #8949

after this FormatSetting is used only in

pub trait TypeSerializer<'a>: Send + Sync {
    fn serialize_json_values(&self, _format: &FormatSettings) -> Result<Vec<Value>>;

    fn serialize_json_object(
        &self,
        _valids: Option<&Bitmap>,
        _format: &FormatSettings,
    ) -> Result<Vec<Value>>;

    fn serialize_json_object_suppress_error(
        &self,
        _format: &FormatSettings,
    ) -> Result<Vec<Option<Value>>>;
}

@vercel
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Nov 24, 2022 at 9:46AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 24, 2022
@BohuTANG BohuTANG merged commit 8874e29 into datafuselabs:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants