Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cluster): try fix broken pipe or connect reset #9104

Merged
merged 2 commits into from Dec 6, 2022

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Dec 6, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fix(cluster): try fix broken pipe or connect reset

When we use two-way streaming grpc for data exchange, if the client side is closed and the server side reads data immediately. we will get a broken pipe or connect reset error.
In this pr: we use the ClosingClient to notify the server side to close the connection for avoid errors.

fixes #8221
fixes #7986

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Dec 6, 2022 at 7:27AM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Dec 6, 2022
@zhang2014
Copy link
Member Author

zhang2014 commented Dec 6, 2022

The test is still in progress. before applying this pr, we will get error when run tpch q5(~10 times). after applying this pr, no any error has occurred (~261 times).

260 times

Running 1 stateless tests.

13_0005_q5:                                                             [ OK ]

1 tests passed. 0 tests skipped.
261 times

Running 1 stateless tests.

13_0005_q5:                                                             [ OK ]

1 tests passed. 0 tests skipped.

@zhang2014 zhang2014 marked this pull request as ready for review December 6, 2022 08:00
@zhang2014
Copy link
Member Author

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2022

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/dev-linux.yml without workflows permission
err-code: FEC32

@BohuTANG BohuTANG merged commit 02f3b25 into datafuselabs:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
3 participants