Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check connection params #9437

Merged
merged 4 commits into from Jan 2, 2023

Conversation

ariesdevil
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Check input connection params when do parse URI.

Closes #8380

@vercel
Copy link

vercel bot commented Dec 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jan 1, 2023 at 2:25PM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Dec 31, 2022
@ariesdevil ariesdevil marked this pull request as ready for review December 31, 2022 20:42
@BohuTANG BohuTANG requested a review from Xuanwo January 1, 2023 00:30
@ariesdevil
Copy link
Member Author

A little bit of spit for Rust:

The mutability of rust is unusual, and I'm not sure if it has anything to do with its borrow checker.

In Scala or OCaml, the HashMap itself is immutable, but the elements contained in it are mutable.

@ariesdevil ariesdevil requested a review from Xuanwo January 1, 2023 15:15
@BohuTANG BohuTANG merged commit 4e1211e into datafuselabs:main Jan 2, 2023
@ariesdevil ariesdevil deleted the refactor-keywords-check branch January 2, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: external table syntax need key workds check
3 participants