fix(expr): no longer return Variant as common super type #9961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
b41sh
reviewed
Feb 10, 2023
|
@mergify update |
❌ Base branch update has failedrefusing to allow a GitHub App to create or update workflow |
sundy-li
reviewed
Feb 11, 2023
andylokandy
commented
Feb 16, 2023
andylokandy
commented
Feb 16, 2023
tests/sqllogictests/suites/duckdb/issues/rigger/test_non_equality_right_join.test
Outdated
Show resolved
Hide resolved
andylokandy
commented
Feb 16, 2023
andylokandy
force-pushed
the
common_super_type
branch
from
806b20b
to
c126d02
Compare
andylokandy
commented
Feb 16, 2023
Comment on lines
+452
to
453
| statement error 1001 | ||
| SELECT * FROM (onecolumn AS a JOIN othertype AS b USING(x)) |
There was a problem hiding this comment.
@xudong963 This case is denied, PTAL if it's ok.
sundy-li
approved these changes
Feb 17, 2023
andylokandy
commented
Feb 17, 2023
| | Type | Int64 NULL | Boolean | | ||
| | Domain | {9..=12} ∪ {NULL} | {FALSE, TRUE} | | ||
| | Row 0 | 9 | false | | ||
| | Row 1 | 10 | false | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
Closes #issue