Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main branch cannot compile, please update dependency rocksdb version #1071

Closed
hxzhao527 opened this issue Mar 20, 2024 · 2 comments · Fixed by #1074
Closed

main branch cannot compile, please update dependency rocksdb version #1071

hxzhao527 opened this issue Mar 20, 2024 · 2 comments · Fixed by #1074

Comments

@hxzhao527
Copy link

Describe the bug

Code in branch main cannot be compiled.

To Reproduce

Steps to reproduce the behavior:

  1. git clone git@github.com:datafuselabs/openraft.git
  2. cargo check

Expected behavior

image

Actual behavior

image
image

Env (please complete the following information):

  • Openraft version: current main branch, b3c1f46
  • Rust-toolchain: cargo 1.78.0-nightly (f772ec022 2024-03-01)
  • OS: Linux archlinux 6.7.9-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 08 Mar 2024 01:59:01 +0000 x86_64 GNU/Linux
  • CPU: x86_64

Additional context

  1. command c++ version: c++ (GCC) 13.2.1 20230801

current main brach depends on rocksdb = "0.20.1"

[dependencies]
openraft = { path= "../../openraft", version = "0.10.0", features=["serde", "type-alias"] }
rocksdb = "0.20.1"

the depency chain is

graph LR
    A[openraft] --> B["rocksdb 0.20.1"] --> C["librocksdb-sys-0.10.0+7.9.2"] --> D["rocksdb 444b3f4"]

this version rocksdb c++ code leak header #include <cinttypes> in util/string_util.h fails compiling.
https://github.com/facebook/rocksdb/blob/444b3f4845dd01b0d127c4b420fdd3b50ad56682/util/string_util.h#L9-L14

solution

just update dependency rocksdb to newer version, like 0.22.0.

Copy link

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

@hxzhao527 hxzhao527 changed the title Update dependency rocksdb main branch cannot compile, please update dependency rocksdb version Mar 20, 2024
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Mar 20, 2024
@drmingdrmer
Copy link
Member

Thank you for reminding! Let me fix it!

drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Mar 20, 2024
drmingdrmer added a commit that referenced this issue Mar 20, 2024
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants