Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join forces? #4

Closed
thedodd opened this issue Sep 3, 2021 · 3 comments
Closed

Join forces? #4

thedodd opened this issue Sep 3, 2021 · 3 comments

Comments

@thedodd
Copy link
Contributor

thedodd commented Sep 3, 2021

Hello datafuse team! I just wanted to open a channel of communication and see if you all would be interested in getting this fork merged upstream. I know it is 111 commits difference at this point, but taking the changes and adding some folks as co-maintainers would be awesome for the overall health of the async-raft project.

Just let me know, cheers 🍻

@drmingdrmer
Copy link
Member

Feel free to merge back every of the commits back to upstream!

@semirix
Copy link

semirix commented Sep 10, 2021

@drmingdrmer Is it important for datafuse to maintain their own separate fork or would you be open to being an upstream maintainer?

@drmingdrmer
Copy link
Member

@drmingdrmer Is it important for datafuse to maintain their own separate fork or would you be open to being an upstream maintainer?

It depends.
For now we need to move quickly improving features or fixing bugs.

And to be honest, there are some personal style in the latest commits. 🤔
E.g. I merged most term, index tuple into a LogId.

And I've changed some of the API that make it easy to use with a real storage(sled based as @thedodd suggested).

And there will be some optimization that is not included in raft spec.
E.g. the membership representation. And the messy leadership management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants