Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize RaftStorage API: remove get_membership_config, add last_membership_in_log #59

Closed
Tracked by #39
drmingdrmer opened this issue Jan 4, 2022 · 1 comment · Fixed by #60
Closed
Tracked by #39
Assignees
Labels
A-store Area: storage

Comments

@drmingdrmer
Copy link
Member

drmingdrmer commented Jan 4, 2022

Goal: minimize the work for users to implement a correct raft application.

RaftStorage provides default implementations for get_membership()
and last_membership_in_log().

These two methods just can be implemented with other basic user impl
methods and do not need users to impl them any more.

@drmingdrmer drmingdrmer self-assigned this Jan 4, 2022
@drmingdrmer drmingdrmer added the A-store Area: storage label Jan 4, 2022
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

drmingdrmer referenced this issue in drmingdrmer/openraft Jan 4, 2022
…bership_in_log() and get_membership() with default impl

Goal: minimize the work for users to implement a correct raft application.

Now RaftStorage provides default implementations for `get_membership()`
and `last_membership_in_log()`.

These two methods just can be implemented with other basic user impl
methods.

- fix: #59
drmingdrmer referenced this issue in drmingdrmer/openraft Jan 4, 2022
…bership_in_log() and get_membership() with default impl

Goal: minimize the work for users to implement a correct raft application.

Now RaftStorage provides default implementations for `get_membership()`
and `last_membership_in_log()`.

These two methods just can be implemented with other basic user impl
methods.

- fix: #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-store Area: storage
Projects
None yet
1 participant