change: trait RaftStore: remove get_membership_config(), add last_membership_in_log() and get_membership() with default impl #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bership_in_log() and get_membership() with default impl Goal: minimize the work for users to implement a correct raft application. Now RaftStorage provides default implementations for `get_membership()` and `last_membership_in_log()`. These two methods just can be implemented with other basic user impl methods. - fix: #59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
change: trait RaftStore: remove get_membership_config(), add last_membership_in_log() and get_membership() with default impl
Goal: minimize the work for users to implement a correct raft application.
Now RaftStorage provides default implementations for
get_membership()and
last_membership_in_log().These two methods just can be implemented with other basic user impl
methods.