Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flush after write in rocksdb example #618

Closed
drmingdrmer opened this issue Dec 19, 2022 · 2 comments · Fixed by #619
Closed

flush after write in rocksdb example #618

drmingdrmer opened this issue Dec 19, 2022 · 2 comments · Fixed by #619

Comments

@drmingdrmer
Copy link
Member

drmingdrmer commented Dec 19, 2022 •
edited
Loading

In this example, I see the RocksDB wal is flushed during apply_to_state_machine() but not append_to_log(). Is there a reason it isn't flushed in append_to_log()?

Yes you are right.
There should be a flush immediately after every write to RaftStorage.
Let me fix it.

Originally posted by @drmingdrmer in #418 (comment)
@github-actions
Copy link

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

@drmingdrmer drmingdrmer mentioned this issue Dec 19, 2022
Merged
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Dec 19, 2022
@drmingdrmer
Refactor: flush after every write in rocksdb example
33f639f 
- Fix: datafuselabs#618
@mergify mergify bot closed this as completed in #619 Dec 19, 2022
@avantgardnerio
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: flush after every write in rocksdb example drmingdrmer/openraft
2 participants
@drmingdrmer @avantgardnerio