Updated raft network implementation in example to return unreachable error #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undecidedapollo
force-pushed
the
update-example-unreachable
branch
from
4b75778
to
8c39fc5
Compare
drmingdrmer
reviewed
Mar 16, 2024
There was a problem hiding this comment.
Thank you!
The commit message(not PR title) should be started with a type such as Refactor: , the type could be one of the following:
DataChange - Persistent data change
Change - API breaking change
Feature - API compatible new feature
Improve - Become better without functional changes
Perf - Performance improvement
Dep - dependency update
Doc - doc update
Test - test udpate
CI - CI workflow update
Refactor - refactor without function change.
Fix - fix bug
Fixdoc - fix doc
Fixup - minor change: e.g., fix sth mentioned in a review.
BumpVer - Bump to a new version.
Chore - Nothing important.
Build(deps) - bot: dependabot.
8c39fc5
to
dc76355
Compare
Update the example to return unreachable error for connection errors to prevent immediate retries.
drmingdrmer
force-pushed
the
update-example-unreachable
branch
from
dc76355
to
556bde4
Compare
|
Perfect! Merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Updated network implementation in example to return unreachable error for connection related issues to prevent excessive / immediate retrying.
In reference to #1051
This change is